Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#32221: Updating language around the 'Codespaces Network Bridge' exte… #32299

Merged
merged 1 commit into from
Mar 29, 2024
Merged

#32221: Updating language around the 'Codespaces Network Bridge' exte… #32299

merged 1 commit into from
Mar 29, 2024
+3 −3

Conversation

srudolph-credera
Copy link
Contributor

@srudolph-credera srudolph-credera commented Mar 29, 2024 •
edited
Loading

…nsion to note that it is deprecated

Why:

Closes: #32221

What's being changed (if available, include any code snippets, screenshots, or gifs):

Updating Codespaces private network documentation to note that the GH CLI extension used to create a local network bridge is no longer supported.

Check off the following:

  • I have reviewed my changes in staging, available via the View deployment link in this PR's timeline (this link will be available after opening the PR).

    • For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.

  • For content changes, I have completed the self-review checklist.

@welcome Welcome
Copy link

welcome bot commented Mar 29, 2024

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Mar 29, 2024
@github-actions GitHub Actions
Copy link
Contributor

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.

Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
codespaces/developing-in-a-codespace/connecting-to-a-private-network.md fpt
ghec
 fpt
ghec

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server

@nguyenalex836 nguyenalex836 added content This issue or pull request belongs to the Docs Content team Codespaces Content relating to GitHub Codespaces and removed triage Do not begin working on this issue until triaged by the team labels Mar 29, 2024
@nguyenalex836
Copy link
Contributor

@srudolph-credera Thanks so much for opening a PR with this update! I'll get this merged ✨

@nguyenalex836 nguyenalex836 added this pull request to the merge queue Mar 29, 2024
Merged via the queue into github:main with commit 4295492 Mar 29, 2024
66 checks passed
@github-actions GitHub Actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nguyenalex836 nguyenalex836 nguyenalex836 approved these changes

Assignees
No one assigned
Labels
Codespaces Content relating to GitHub Codespaces content This issue or pull request belongs to the Docs Content team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Connecting to a private network docs appear to reference archived gh-cli extension
2 participants
@srudolph-credera @nguyenalex836